search

gonum / blas

A BLAS implementation for Go [DEPRECATED]
172 stars 16 forks source link

Fix Dnrm2 when the slice contains multiple inf. #136

Closed btracey closed 9 years ago

btracey commented 9 years ago

Fixes #135

btracey commented 9 years ago

Wait. Not sufficient.

btracey commented 9 years ago

PTAL

At least on my machine, OpenBLAS and gonum disagree on the correct behavior with Idamax where there are NaNs present. If you'd like I can log the failure instead of causing a t.Error.

kortschak commented 9 years ago

LGTM with one minor optional comment and yes, I'd like a logged failure rather than an error - with a TODO to remove it when the OpenBLAS bug (yes) is fixed. Can we do that without weakening the other Idamax test cases?

btracey commented 9 years ago

The fuzzer I have ( https://github.com/btracey/blasfuzz/blob/master/onevec/idamax.go ) tests differently if the slice has a NaN value or not. My plan was to do a similar test (if the slice has a NaN, log the failure).

kortschak commented 9 years ago

That approach sounds fair.