Closed vladimir-ch closed 8 years ago
I don't have time to look into this for the next few days. Both things are mysterious.
Has coverage increased because total line count has decreased?
I don't get the coveralls UI, so I cannot confidently interpret it. My command line says:
$ wc -l cblas128/cblas128.go cblas64/cblas64.go
510 cblas128/cblas128.go
510 cblas64/cblas64.go
1020 total
$ git checkout master
Switched to branch 'master'
Your branch is up-to-date with 'origin/master'.
$ wc -l cblas128/cblas128.go cblas64/cblas64.go
497 cblas128/cblas128.go
497 cblas64/cblas64.go
994 total
The link failure isn't repeatable on my machine here, but a restart on travis shows it is there. Presumably libmath is not being specified somewhere that we were getting for free previously.
I tried to restart a rebuild of master and now it is failing too, previously it wasn't. Shall I try to add -lm
to gonum/blas/.travis/linux/OpenBLAS/install.sh
?
I guess it's worth a try. Please take a look at the failure on Brendan's dsterf PR in lapack and see if that failure is the same - I restarted one to see the log (travis doesn't like this machine for unknowable reasons) and it passed, but the rest failed.
That failure is also from the linker but the reason is different, many errors about undefined references to LAPACKE functions.
And it doesn't fail for me here either. I'll try replicating on my workstation tomorrow. It's running archaic ubuntu too, so I might be able to repeat there.
Adding -lm
seems promising, the branch openblas-lm is all green on travis. Submitting PR.
LGTM
Presumably you will rebase this onto the new master with -lm?
The build passes, no rebase is necessary. Merging.
I'm confused. Why does the build fail due to missing sqrt and why has the coverage increased?