pass through exit status from install cmds

[jonlawlor]

By checking the exit status from the various install commands (apt-get, git, curl, etc.) we can set the travis exit status to failure in the right spot, so that it is obvious when there is a network failure or other temporary problem.

This should help with #155 - the only shortcoming is that it doesn't pass through the exit code and instead assigns 1 to all failures, but it should be OK for travis, and in any case apt-get, curl, git, and go get do not have equivalent exit codes.

PTAL

[vladimir-ch]

Could you please also add a similar modification to the ATLAS install script? Then LGTM. Thanks!

[jonlawlor]

I've added it to the ATLAS install script, but currently there is no travis build environment for it so I can't test.

[jonlawlor]

Well, it looks like travis has enabled multi-os (and OSX builds) by default, and we just need to change the .travis.yml script. There will probably be issues because ATLAS comes with xtools if I recall correctly. I can enable it but then have it ignore errors, I'll give it a shot this Saturday.

[vladimir-ch]

I've added it to the ATLAS install script, but currently there is no travis build environment for it so I can't test.

I know but I thought it would be good to have it ready for what if one day ...

Well, it looks like travis has enabled multi-os (and OSX builds) by default, and we just need to change the .travis.yml script.

Having the tests run also on OSX would be indeed very nice.

There will probably be issues because ATLAS comes with xtools if I recall correctly.

Do you mean the Accelerate framework?

[btracey]

Just know that I've had ATLAS installation problems on OSX in the past, and that ATLAS also fails at least part of our test suite at the moment.

[sbinet]

wouldn't the same thing be achieved with set -e put at the top? see: http://www.davidpashley.com/articles/writing-robust-shell-scripts/#id2382181

[jonlawlor]

Looks like it! I wasn't aware of that command (not surprising because I am not a bash expert). I'll research it a little and then modify as appropriate.

[jonlawlor]

Also, @vladimir-ch - yes, I meant the Accelerate framework and I guess I got them mixed up in my head for a bit. I'll revise my statement earlier and just say that I'll be fiddling with travis, ATLAS, Accelerate, and OSX over the weekend (in a fork).

[vladimir-ch]

Will you use the set -e that @sbinet suggested?

[jonlawlor]

From reading http://mywiki.wooledge.org/BashFAQ/105 it seems like there is some disagreement regarding if it is a good idea to use, and the alternative is to check error status as I am doing here. set -e was an attempt to avoid the repetition, but I'd rather be careful than DRY.

[jonlawlor]

PTAL

[jonlawlor]

ping @sbinet @vladimir-ch

[vladimir-ch]

PTAL

[jonlawlor]

Uh, at what in particular?

[sbinet]

LGTM