search

gonum / blas

A BLAS implementation for Go [DEPRECATED]
172 stars 16 forks source link

remove path exclusion from git diff #187

Closed jonlawlor closed 8 years ago

jonlawlor commented 8 years ago

Looks like the :!.travis exclusion rule is not implemented in the version of git that travis is using.

This pull will also have to make changes to the CI process so that the directory is actually unchanged, instead of just ignored.

jonlawlor commented 8 years ago

I guess this didn't need other cleanup and ignoring the .travis directory was unnecessary. PTAL @kortschak

kortschak commented 8 years ago

The git complaint is less of a concern for me, though I guess it's nice. What I don't like is that go generate can fail and travis seems not to care.

Locally, I see this:

$ go generate
generate_blas.go:23:2: cannot find package "github.com/gonum/internal/binding" in any of:
    /home/daniel/Development/go/src/github.com/gonum/internal/binding (from $GOROOT)
    /home/daniel/Development/src/github.com/gonum/internal/binding (from $GOPATH)
doc.go:5: running "go": exit status 1
$ echo $?
1

So we should be checking the success of the go generate invocations.

jonlawlor commented 8 years ago

Oh, right, I figured it had to do with the git diff. set -ex should fix it.

kortschak commented 8 years ago

Thanks

LGTM