gonum / blas

A BLAS implementation for Go [DEPRECATED]
172 stars 16 forks source link

Adddtbsv #26

Closed btracey closed 9 years ago

btracey commented 9 years ago

This implements the Dtbsv function and adds tests.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+2.19%) when pulling 7083f5e49311380cdb186684557b53332dc254ca on adddtbsv into 33f78a29b02f0400a1b0a8559c1e2c9f863a5d18 on master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+2.19%) when pulling 7083f5e49311380cdb186684557b53332dc254ca on adddtbsv into 33f78a29b02f0400a1b0a8559c1e2c9f863a5d18 on master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+2.19%) when pulling 7083f5e49311380cdb186684557b53332dc254ca on adddtbsv into 33f78a29b02f0400a1b0a8559c1e2c9f863a5d18 on master.

btracey commented 9 years ago

Please review #28 before this one. I'll fix this up when that's through.

kortschak commented 9 years ago

Just a thought, but would it be worthwhile to compare the banded operations to the more expensive dense operations to determine correctness in addition to the explicit answers you provide?

LGTM

btracey commented 9 years ago

How would you recommend doing that? Generate random matrices of various sizes?

kortschak commented 9 years ago

Yeah, or at least do the same operation with the input matrices you have here.