Fixed implementation of dgbmv and added tests.

gonum / blas

A BLAS implementation for Go [DEPRECATED]

172 stars 16 forks source link

Fixed implementation of dgbmv and added tests. #28

Closed btracey closed 9 years ago

btracey commented 9 years ago

The old implementation of dgbmv was written in column-major style and had a few bugs. This writes it as row-major and adds a more robust test suite

btracey commented 9 years ago

Please review this before #26 . I'll fix that once this is through.

coveralls commented 9 years ago

Coverage increased (+1.63%) when pulling fb08479b75b0aa8aacde8600e514f6866bcc9cc2 on fixdgbmv into 33f78a29b02f0400a1b0a8559c1e2c9f863a5d18 on master.

btracey commented 9 years ago

The comments on the top of #26 will be helpful in understanding the banded layout (they can be added when #26 gets added).

btracey commented 9 years ago

@kortschak

coveralls commented 9 years ago

Coverage increased (+1.75%) when pulling 65cc4148f404cb3f53fa766b71098029b715a1bd on fixdgbmv into 33f78a29b02f0400a1b0a8559c1e2c9f863a5d18 on master.

coveralls commented 9 years ago

Coverage increased (+1.75%) when pulling 65cc4148f404cb3f53fa766b71098029b715a1bd on fixdgbmv into 33f78a29b02f0400a1b0a8559c1e2c9f863a5d18 on master.

kortschak commented 9 years ago

LGTM