gonum / blas

A BLAS implementation for Go [DEPRECATED]
172 stars 16 forks source link

Fixdtbmv #29

Closed btracey closed 9 years ago

btracey commented 9 years ago

I'll fix up a bit after #28

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.2%) when pulling 695ca4486cabda17086c482a7dd6ac0c43ba2fcf on fixdtbmv into 33f78a29b02f0400a1b0a8559c1e2c9f863a5d18 on master.

btracey commented 9 years ago

PTAL.

I had some issues with merging in git, so I just created a new branch. I responded to all of the comments although apparently Dtrsv has a bug in it so I'm leaving the comparison code uncommented for now.

btracey commented 9 years ago

Err, commented.

btracey commented 9 years ago

Sorry, the above comment was on the wrong PR. This one is now up to date with master.

PTAL.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.19%) when pulling 9e8f10fdfa6f5efd65967878c303075a10cccaef on fixdtbmv into 525a9ce9ea459a4e9ad62071cb909413d8884b7a on master.

kortschak commented 9 years ago

LGTM after comments addressed.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.28%) when pulling d0c2b694dbf3573edda7d2f95b11b5c5a4a11adf on fixdtbmv into be8a6a6cca55e928ddb3ae5323c8434d1d83293f on master.