Was this here because you had parallel branches? Next time I'd suggest having a support PR with common helper functions first, then after that is in - if you want separate PRs for each - then do those in parallel. This collection was pretty confusing for me because of the similarity of the code and the apparent repetition of conflicting changes - exacerbated by the loss of travis. I just suspended disbelief and hped for the best.
LGTM
Was this here because you had parallel branches? Next time I'd suggest having a support PR with common helper functions first, then after that is in - if you want separate PRs for each - then do those in parallel. This collection was pretty confusing for me because of the similarity of the code and the apparent repetition of conflicting changes - exacerbated by the loss of travis. I just suspended disbelief and hped for the best.