search

gonum / blas

A BLAS implementation for Go [DEPRECATED]
172 stars 16 forks source link

Error in Dtrsm length check #51

Closed btracey closed 9 years ago

btracey commented 9 years ago

In Dtrsm, there is a check for the size of A (currently lines 2831 - 2839 of blas.go in cblas). The check tests assuming that A is an nxm or mxn matrix, but A is always symmetric. If on the left it is an M x M matrix ( {MxM} * {MxN} = {MxN}), and when on the right it is an NxN matrix.

kortschak commented 9 years ago

Do you have a test in your suite for that?

btracey commented 9 years ago

I don't have a targeted test, but I discovered the error because the Dtrsm test I am developing failed.

kortschak commented 9 years ago

That's good enough for me.