gonum / blas

A BLAS implementation for Go [DEPRECATED]
172 stars 16 forks source link

fix some golint warnings & import order #71

Closed fhs closed 9 years ago

fhs commented 9 years ago

The auto-generated files are ignored for now.

btracey commented 9 years ago

Where do I get the most up to date version of go lint? My local copy doesn't return any errors, which is clearly false.

fhs commented 9 years ago

go get -u github.com/golang/lint/golint cd $GOPATH/src/github.com/gonum/blas golint ./...

On Fri, Jan 2, 2015 at 5:20 PM, Brendan Tracey notifications@github.com wrote:

Where do I get the most up to date version of go lint? My local copy doesn't return any errors, which is clearly false.

— Reply to this email directly or view it on GitHub https://github.com/gonum/blas/pull/71#issuecomment-68568113.

btracey commented 9 years ago

Thanks. I guess mine was out of date.

What's wrong with a leading k on a variable name?

btracey commented 9 years ago

Or rather, what is the common thing people do to make that a golint error?

btracey commented 9 years ago

LGTM when the "A" are removed.

fhs commented 9 years ago

It's apparently a "common styles from other languages that don't belong in Go." See: https://github.com/golang/lint/blob/master/lint.go#L486

I'm not sure what language it's referring to. Maybe people use "k" to mean "constant".

btracey commented 9 years ago

For the curious http://stackoverflow.com/questions/500030/what-is-the-significance-of-starting-constants-with-k

btracey commented 9 years ago

Thanks for the fixes.