search

gonum / graph

Graph packages for the Go language [DEPRECATED]
250 stars 39 forks source link

graphs/gen/batagelj_brandes.go should be renamed to erdos_renyi #191

Closed jcao219 closed 7 years ago

jcao219 commented 7 years ago

I think it would be more recognizable. This looks like the Erdos-Renyi model. Thoughts?

kortschak commented 7 years ago

What are you proposing? batagelj_brandes.go contains a variety of graph generators, some of which are in that family, but are in a paper by Batagelj and Brandes - as noted in the file. Changing the name of the file would not make any of the functions more discoverable since the godoc links to the correct location.

jcao219 commented 7 years ago

Oh, I didn't see the small world graph generator.

I guess the documentation for the two functions should just mention that G(n,p) and G(n,m) are also known as Erdos-Renyi graphs.

On Mon, Jan 9, 2017 at 4:32 PM, Dan Kortschak notifications@github.com wrote:

What are you proposing? batagelj_brandes.go contains a variety of graph generators, some of which are in that family, but are in a paper by Batagelj and Brandes - as noted in the file. Changing the name of the file would not make any of the functions more discoverable since the godoc links to the correct location.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gonum/graph/issues/191#issuecomment-271429046, or mute the thread https://github.com/notifications/unsubscribe-auth/AAMKEYD3-jCDOcfSXvecpt1taWWdq8lcks5rQrVrgaJpZM4LeMEN .

kortschak commented 7 years ago

SGTM