search

gonum / hdf5

hdf5 is a wrapper for the HDF5 library
BSD 3-Clause "New" or "Revised" License
131 stars 33 forks source link

Support dataset compression with ZLIB. #48

Closed yuanqj closed 5 years ago

yuanqj commented 5 years ago

Support dataset compression for both pre-defined compression filter ZLIB in HDF5.

kortschak commented 5 years ago

Do the tests pass for you locally?

yuanqj commented 5 years ago

Yes. My local HDF5 is v1.10.0. And the build server is v1.8.11. According to HDF5's change log, this break should be caused by the version mismatch. https://support.hdfgroup.org/ftp/HDF5/current/src/unpacked/release_docs/HISTORY-1_8_0-1_10_0.txt

yuanqj commented 5 years ago

Do we have a plan to support v1.10.x?

sbinet commented 5 years ago

Do we have a plan to support v1.10.x?

IIRC, we delayed a bit the explicit support of v1.10.x because at the time it wasn't well distributed (e.g. on travis.)

if we manage to setup travis to use 1.10.x, then I guess we could explicitly support 1.10.x (and support 1.8.x on a best effort basis.)

sbinet commented 5 years ago

@kortschak should we squash+merge or just rebase+merge?

kortschak commented 5 years ago

I think this can be squashed to "hdf5: add zlib dataset compression support".