search

gonum / hdf5

hdf5 is a wrapper for the HDF5 library
BSD 3-Clause "New" or "Revised" License
131 stars 33 forks source link

hdf5: add ObjectTypeByIndex to CommonFG #78

Closed sbinet closed 3 years ago

sbinet commented 3 years ago

This CL adds a new method to CommonFG, ObjectTypeByIndex, to retrieve the type of an object in a file or a group, prior to read from storage.

Fixes #77.

sbinet commented 3 years ago

not completely happy with the naming of the new GType constants... happy to get some input there.

dcu commented 3 years ago

what's wrong with the naming?

sbinet commented 3 years ago

I wasn't completely happy with the H5G_GROUP naming as, from the user point of view, the stuttering isn't pretty (hdf5.H5G_GROUP...).

a better naming scheme would be nice.

anyways... PTAL?

kortschak commented 3 years ago

We can just blame it on the HDF Group; I think it's reasonable to keep constants in line with the names they have there (ugly as they may be) to ease finding of documentation.

sbinet commented 3 years ago

PTAL