search

gonum / internal

Internal routines for the gonum project [DEPRECATED]
21 stars 9 forks source link

travis: update test matrix #25

Closed kortschak closed 8 years ago

kortschak commented 8 years ago

go1.5.2 -> go1.5.3 go1.6beta2 -> go1.6rc1

kortschak commented 8 years ago

@jonlawlor Any idea why github interprets the coveralls result as a failure? There is no change and the builds were successful.

jonlawlor commented 8 years ago

I think it is failing because of the "-0.0%" decrease in coverage. Digging a bit deeper it looks like coveralls will mark a test as failed if coverage decreases by too much, and I guess the default is 0%, so any decrease in coverage causes the test to fail. Digging a bit deeper again, negative 0.0% is caused by a floating point issue on coveralls side. The easiest way to fix is to set an amount of coverage that we are comfortable with losing, basically an epsilon. It is kind of dumb on coveralls side, so I expect they'll address this eventually.

For now I'll set the "COVERAGE DECREASE THRESHOLD FOR FAILURE" to 1%.

jonlawlor commented 8 years ago

After setting the threshold to 1% the test passed. I'll set it for the other gonum packages as well. Do you prefer a smaller % than 1%?

kortschak commented 8 years ago

1% is fine. Should we file an issue with coveralls?

jonlawlor commented 8 years ago

There already is one at https://github.com/lemurheavy/coveralls-public/issues/565

kortschak commented 8 years ago

Thanks for following that up. Dodgey decision on their part IMO.

kortschak commented 8 years ago

TBR @gonum/developers