search

gonum / matrix

Matrix packages for the Go language [DEPRECATED]
446 stars 53 forks source link

mat64: remove stale TODO #353

Closed kortschak closed 8 years ago

kortschak commented 8 years ago

@btracey / @vladimir-ch Please take a look.

vladimir-ch commented 8 years ago

For my better understanding: why is it stale?

kortschak commented 8 years ago

I need to think more about this.

kortschak commented 8 years ago

OK. Done thinking. It's clear that we have decided that Clone is something that does not preserve the receiver's state in any way (for better or worse). The original design in my head when I started the shadowing code was to engineer safe work places when there was shadowing. On discussion with @btracey we decided that restriction was more sensible. The TODO here was written when overlap detection would have allowed Clone to work somewhere else in case of an overlap. That can't happen anymore.

I'll add some extra documentation to Cloner and Dense.Clone, and I also will add the *Vector path.

vladimir-ch commented 8 years ago

LGTM