search

gonum / matrix

Matrix packages for the Go language [DEPRECATED]
446 stars 53 forks source link

mat64: add reuseAsZeroed and use in Exp #371

Closed kortschak closed 8 years ago

kortschak commented 8 years ago

WIP: Waiting to add use in QFromQR.

btracey commented 8 years ago

I guess this is okay, but I would be happier if there was less copying from reuseAs. I don't see a good way around it though.

LGTM

kortschak commented 8 years ago

This PR reduces copying when complete (after the QFromQR use is in). There is the option to merge reuseAs and reuseAsZeroed by passing a bool, but I don't like the readability impact of that (which is why both use and useZeroed exist).

btracey commented 8 years ago

Yea, agreed on both accounts. Maybe add a comment to reuseAs that if that implementation changes, reuseAsZeroed should change as well?

kortschak commented 8 years ago

Will do.

kortschak commented 8 years ago

OK, this is ready.

PTAL

btracey commented 8 years ago

LGTM with fix.