mat64: tighten definition of Dot

gonum / matrix

Matrix packages for the Go language [DEPRECATED]

446 stars 53 forks source link

mat64: tighten definition of Dot #392

Closed kortschak closed 7 years ago

kortschak commented 7 years ago

@btracey Please take a look.

@sjwhitworth This will break github.com/sjwhitworth/golearn/metrics/pairwise, but the breakage is fixed by using mat64.Norm here and here. (You'll also get a performance improvement by using mat64.Vector rather than mat64.Dense if that will work for you.)

btracey commented 7 years ago

The code is so much simpler too.

LGTM