This seems like the best signature for Factorize, but I'm a bit worried about the confusion it will cause. I think many users have only heard of "eigenvectors" and don't realize the two classes. I'm hoping that the documentation and the name asymmetry (which in my vision will eventually become Eigenvectors and LeftEigenvectors as methods on Dense) points users to what they want.
This seems like the best signature for Factorize, but I'm a bit worried about the confusion it will cause. I think many users have only heard of "eigenvectors" and don't realize the two classes. I'm hoping that the documentation and the name asymmetry (which in my vision will eventually become Eigenvectors and LeftEigenvectors as methods on Dense) points users to what they want.