search

gonum / matrix

Matrix packages for the Go language [DEPRECATED]
446 stars 53 forks source link

mat64: extend TestInverse #413

Closed kortschak closed 7 years ago

kortschak commented 7 years ago

@vladimir-ch @btracey Please take a look for discussion.

The single failing case is one where I have ignored the shadowing restrictions, so we do not guarantee that it will work. I am not entirely sure how I want to handle this. I think that probably leaving the test case in as a comment explaining why it would fail is the correct answer. What are your views?

Fixes #412.

ChristopherRabotin commented 7 years ago

I don't see any test on singular matrices, which is how #410 got to slip through the cracks. Maybe a few should be added? Or are those expected to be covered in #411 ?

kortschak commented 7 years ago

No, I'll leave that for @vladimir-ch in #411. This set of tests is to ensure that our typish system works properly.

btracey commented 7 years ago

I think leaving the test commented is good. It's probably nice to have a few shadowing examples somewhere when we have somewhere to put that kind of extra documentation.

kortschak commented 7 years ago

PTAL

btracey commented 7 years ago

LGTM

Sorry for the delay, I missed you had fixed.