all: define vg.FontExtents.Descent as a positive value to follow x/image/font/sfnt convention

gonum / plot

A repository for plotting and visualizing data

BSD 3-Clause "New" or "Revised" License

2.74k stars 203 forks source link

Closed sbinet closed 3 years ago

sbinet commented 3 years ago

Please take a look.

sbinet commented 3 years ago

indeed, but IIRC, that's not the same Descent. it's the one internal to gofpdf.

do you want me to add a comment about that?

kortschak commented 3 years ago

Sorry, no. My mistake.

sbinet commented 3 years ago

it's finnicky business.

kortschak commented 3 years ago

Injudicious use of grep without following up with proper static analysis.