search

gonum / plot

A repository for plotting and visualizing data
BSD 3-Clause "New" or "Revised" License
2.72k stars 202 forks source link

all: bump to git.sr.ht/~sbinet/gg@v0.3.1 #741

Closed sbinet closed 2 years ago

sbinet commented 2 years ago

Please take a look.

Fixes #687. Fixes #645. Fixes #559.

kortschak commented 2 years ago

Looks like some module clean up needs to happen.

sbinet commented 2 years ago

it's probably coming from x/image itself.

codecov-commenter commented 2 years ago

Codecov Report

Merging #741 (9e9193f) into master (08671db) will increase coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #741      +/-   ##
==========================================
+ Coverage   73.22%   73.23%   +0.01%     
==========================================
  Files          56       58       +2     
  Lines        5154     5366     +212     
==========================================
+ Hits         3774     3930     +156     
- Misses       1196     1243      +47     
- Partials      184      193       +9
Impacted Files Coverage Δ
vg/vgimg/vgimg.go 50.00% <ø> (+2.90%) :arrow_up:
vg/vggio/context.go 100.00% <0.00%> (ø)
vg/vggio/vggio.go 67.37% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 08671db...9e9193f. Read the comment docs.

sbinet commented 2 years ago

PTAL

kortschak commented 2 years ago

Do we have a test case for the bug that this fixes?

sbinet commented 2 years ago

in ~sbinet/gg, yes:

but you're right that one of the referenced gonum/plot issues could be turned into a proper test. I'll do that tomorrow (Paris' time)

kortschak commented 2 years ago

Thanks. In that commit, I still don't understand the need for the slackness in the pixel distance; I was unable to get any of the test suite of gg to fail by changing it to dx+dy != 0 and the commit that introduced it made no comment about why it was chosen.

sbinet commented 2 years ago

PTAL.

as for your https://github.com/gonum/plot/pull/741#issuecomment-1015894185, I haven't put too much intelligence in ~sbinet/gg yet (?), aiming for just "same codebase, same bugs, save for the one at hand".

there's probably some amount of low hanging fruits to address in this new repo (e.g. reducing the API surface, reusing go-text stuff, ...)