Closed sbinet closed 2 years ago
Merging #751 (fd8154f) into master (c2b6359) will increase coverage by
1.42%
. The diff coverage isn/a
.:exclamation: Current head fd8154f differs from pull request most recent head 6dbf496. Consider uploading reports for the commit 6dbf496 to get more accurate results
@@ Coverage Diff @@
## master #751 +/- ##
==========================================
+ Coverage 73.32% 74.74% +1.42%
==========================================
Files 56 58 +2
Lines 5154 7337 +2183
==========================================
+ Hits 3779 5484 +1705
- Misses 1191 1657 +466
- Partials 184 196 +12
Impacted Files | Coverage Δ | |
---|---|---|
vg/geom.go | 76.00% <0.00%> (-5.25%) |
:arrow_down: |
plotter/quartile.go | 67.97% <0.00%> (-2.12%) |
:arrow_down: |
palette/hsva.go | 89.74% <0.00%> (-1.79%) |
:arrow_down: |
text/plain.go | 88.63% <0.00%> (-1.69%) |
:arrow_down: |
plotter/errbars.go | 86.56% <0.00%> (-1.44%) |
:arrow_down: |
vg/vgpdf/vgpdf.go | 68.58% <0.00%> (-1.29%) |
:arrow_down: |
axis.go | 85.96% <0.00%> (-0.99%) |
:arrow_down: |
vg/tee.go | 76.00% <0.00%> (-0.93%) |
:arrow_down: |
palette/moreland/smooth.go | 85.91% <0.00%> (-0.63%) |
:arrow_down: |
plotter/line.go | 90.38% <0.00%> (-0.42%) |
:arrow_down: |
... and 45 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@kortschak, do you understand why Go-1.19's test fails with Process completed with exit code 1.
while there are no error being reported by go test ./...
?
(also: could you please remove the expected flag for 1.17.x
? thanks)
I have no idea why that is failing. It passes locally.
Maybe try running the tests if -v
to see if that gives a hint. Otherwise, bisecting the packages to see which package is causing the problem might help.
aha! that was actually test -z "$(gofmt -d .)"
(GitHub's CI UI was greatly misleading...)
That's horrific.
PTAL
I guess it doesn't handle well shell builtin functions ?
(anyways, there was also a bug in .ci/check-formatting.sh
which should have made the initial error easier to spot)
PTAL
(force-push is only to clean up git history, no code change)
Please take a look.