Closed sbinet closed 1 year ago
one existential question: should we create one gigantic glyphbox (or rather 4, one around each of the xmin
, xmax
, ymin
, and ymax
points), or one for each of line's points (as is done in this PR) ?
Patch coverage: 100.00
% and project coverage change: +1.50
:tada:
Comparison is base (
1cd1f0e
) 73.34% compared to head (49a83ba
) 74.85%.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I think what you have is probably the best approach. I am concerned about the impact on the step plot though. It does weird things to the alignment in ways that I would not expect.
Fixes #761.
Please take a look.