Closed sbinet closed 1 year ago
this isn't the final answer: the new Gio API doesn't lend itself very nicely with our Push/Pop
semantics.
see 1 for more details.
(but we don't use explicitly Push/Pop
in the vg/vggio
tests. I'd expect plot/plotter.Field.Plot
to fail)
also, it seems the latest Gio version has a somewhat different kerning algorithm.
Patch coverage: 75.20
% and project coverage change: +1.69
:tada:
Comparison is base (
78cf2c9
) 73.43% compared to head (10ff9ab
) 75.13%.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
this needs https://lists.sr.ht/~eliasnaur/gio-patches/patches/40703
I haven't understood (yet?) why the embedded image is so blurry.
I haven't understood the blur, but I know where it comes from: https://lists.sr.ht/~eliasnaur/gio/%3CCS8BHEBZ9GR5.NAXSHL22P0UG%40clrinfopc42%3E#%3CCSBMYF60V5V2.38PUCTE2N4NPI@clrinfopc42%3E
so the blur comes from a different filtering algorithm used deep inside Gio.
I guess we'll have to do the rescaling by hand CPU-side, with image/draw
.
well, this is the best I could come up with. still not on par with what we used to have though...
(I have tried different filters from x/image/draw
. the NN is what looked best to my eyes. perhaps we should allow to optionally provide a way to use a user-provided x/image/draw.Scaler
?)
PTAL
Please take a look.