search

gonum / stat

Statistics package for Go [DEPRECATED]
195 stars 23 forks source link

AddTransformNormal #103

Closed btracey closed 8 years ago

btracey commented 8 years ago

PTAL @sbinet @kortschak

Calling this TransformNormal because I think there is room for a Transform() that works on slices generated from the standard uniform.

This is useful for comparing results under two different Gaussians. I can generate a bunch of vectors from a standard normal, and then test the results using Transform with different Gaussians.

sbinet commented 8 years ago

LGTM (but I am not an expert, by far, so... please wait for another LGTM)

btracey commented 8 years ago

Ping @vladimir-ch @jonlawlor

jonlawlor commented 8 years ago

LGTM.

btracey commented 8 years ago

PTAL

vladimir-ch commented 8 years ago

Sorry for not paying attention earlier. Is TransformNorm a better name than TransformNormal? I don't like that the abbreviation becomes a completely different concept (but I can bend easilly).

kortschak commented 8 years ago

I'm not particularly fussed. The reason I suggested TransformNorm over TransformNormal was that the parameter is called norm and norm is the usual name for normal operations in places like R.

What is the completely different concept that it becomes?

vladimir-ch commented 8 years ago

Probably because of a different background, for me these two words don't mesh together. When I see Norm, I think of a norm of a vector. But then Transform doesn't fit, and I become confused. If you think it's fine and if it's used in other places (I know nothing about R), then I'm happy.

kortschak commented 8 years ago

OK. MATLAB uses norm in the sense you expect. Maybe we should expand to TransformNormal and the parameter to normal to avoid any confusion. @btracey can make the call.

btracey commented 8 years ago

Changed back to TransformNormal

btracey commented 8 years ago

ping

kortschak commented 8 years ago

LGTM