search

gonum / stat

Statistics package for Go [DEPRECATED]
195 stars 23 forks source link

ROC: Alternate Signature #110

Closed Armadilloa16 closed 5 years ago

Armadilloa16 commented 8 years ago

Found some free time, so I had a go at this.

As per #104 the new ROC function takes cutoffs as an argument instead of the number of cutoffs n, and there is a helper function EquallySpaced for generating equallly spaced cutoffs. The need for a helper function to maintain the old functionality is abit clunky but this allows for particular cutoffs of interest to be defined which wasn't the case before, and I think the code is (slightly) easier to read.

PTAL @kortschak @sbinet :)

kortschak commented 5 years ago

What do we want to do with this?

kortschak commented 5 years ago

@btracey?

btracey commented 5 years ago

I think this is a good change, but it doesn't seem like it's ready to submit immediately. I would suggest we file an issue if someone wants to take the helm

vladimir-ch commented 5 years ago

There is already an issue https://github.com/gonum/gonum/issues/708 in the new repository which has been moved there from this one.

I'm closing this PR but please feel free @Armadilloa16 to port this PR to the new repository https://github.com/gonum/gonum