gonzalezreal / swift-markdown-ui

Display and customize Markdown text in SwiftUI
MIT License
2.25k stars 267 forks source link

The deprecation warning for onOpenMarkdownLink seems incorrect #207

Closed tkirby closed 1 year ago

tkirby commented 1 year ago

Describe the bug The deprecation warning for onOpenMarkdownLink seems to be incorrect. The message suggests that "MarkdownImageHandler" has been superseded by the "ImageProvider" protocol and its conforming types "DefaultImageProvider" and "AssetImageProvider", which is not relevant to onOpenMarkdownLink.

Checklist

Steps to reproduce

  1. Create a SwiftUI project.
  2. Add a markdown view to the project.
  3. Implement onOpenMarkdownLink method in the view.
  4. Observe the deprecation warning for onOpenMarkdownLink.

Expected behavior The deprecation warning for onOpenMarkdownLink should provide relevant information related to the deprecation and point to what has replaced it if applicable.

Screenshots N/A

Version information

MarkdownUI: 2.0.2 OS: iOS 15

gonzalezreal commented 1 year ago

Thanks for raising this documentation issue.