search

gonzalo-bulnes / simple_token_authentication

Simple (and safe*) token authentication for Rails apps or API with Devise.
GNU General Public License v3.0
1.51k stars 238 forks source link

Add support for Rails 6 #347

Closed MatthiasRMS closed 5 years ago

MatthiasRMS commented 5 years ago

So this is the PR related to the ongoing discussion about making this library compatible with Rails 6.

@gonzalo-bulnes I've changed the restrictions. You asked to write a spec about the Rails 6 compatibility. Where should I do this ? I couldn't find the specs for other versions in the spec folder besides the different gemfiles. I've added a gemfile for this version which works with appraisal.

I haven't done much so far, some directions on where to go from here would be greatly appreciated 😉

gonzalo-bulnes commented 5 years ago

Also, you likely want to update the CHANGELOG. I'd put the new addition in the Unreleased section (there is a example in https://keepachangelog.com/en/1.0.0). That section can then be turned into 1.16.0 when buidling the release :slightly_smiling_face:

MatthiasRMS commented 5 years ago

Hi @gonzalo-bulnes ,

I've updated the changelog, let me know if this is sufficient. As for checking deprecations messages, how should I do this ? How can I list the deprecations messages for Rails 6 ? I don't know an easy way to do this 😉

nickcoyne commented 5 years ago

What do we need to do to get these builds passing? Rails 6 has been released.

gonzalo-bulnes commented 5 years ago

Not much @nickcoyne, namely the three last commits in this branch.

@MatthiasRMS Since I cannot add the commits to the branch in your fork, I copied over your commits (also grouped a few changes and reworded commit messages accordingly) to be able to get a green build and ship this. (:tada:)

gonzalo-bulnes commented 5 years ago

So many thanks @MatthiasRMS! :confetti_ball: You can now pull your code with the freshly released v1.16.0 :wink: