search

gonzalo-bulnes / simple_token_authentication

Simple (and safe*) token authentication for Rails apps or API with Devise.
GNU General Public License v3.0
1.51k stars 238 forks source link

Remove a deprecation warning with Rails 6 #359

Closed thomasdarde closed 3 years ago

thomasdarde commented 4 years ago

Adding a simple unscoped on this line avoids firing a Deprecation warning for classes using acts_as_token_authenticatable

Allan-W-Smith commented 4 years ago

Nice, what is the deprecation it is resolving out of interest?

thomasdarde commented 4 years ago

Hi @Allan-W-Smith I think it fixes this one from memory: https://github.com/rails/rails/issues/37629

thomasdarde commented 4 years ago

Hello,

Any plan to integrate this PR ? Thanks !

gonzalo-bulnes commented 3 years ago

Hi @thomasdarde, thank you for the PR and for linking the deprecation warning! :rocket:

For future reference:

DEPRECATION WARNING: Class level methods will no longer inherit scoping from get_employee in Rails 6.1.

gonzalo-bulnes commented 3 years ago

GitHub doesn't seem to be reflecting not picking up the merge, so I'll close the PR, but it is merged @thomasdarde :wink:

gonzalo-bulnes commented 3 years ago

Note: I'll hold on releasing v1.17.1 until I have a better idea of what to do with #367. (I'd rather not release on a red build.)

Allan-W-Smith commented 3 years ago

Never worth releasing on a red build.

If you need help resolving the build I'm happy to help resolve the issues.

Cheers

On Sat, 2 Jan 2021, 23:35 Gonzalo Bulnes Guilpain, notifications@github.com wrote:

Note: I'll hold on releasing v1.17.1 until I have a better idea of what to do with #367 https://github.com/gonzalo-bulnes/simple_token_authentication/issues/367. (I'd rather not release on a red build.)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gonzalo-bulnes/simple_token_authentication/pull/359#issuecomment-753468523, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4INPV3ECFTO4NWT2GNRRTSX4HJLANCNFSM4LXNRI5Q .

gonzalo-bulnes commented 3 years ago

Hi Allan!

Thank you for chiming in! Yes, I'd love a hand! I'm on my way to sleep, but I'm planning on doing some triage tomorrow. Your thoughts are very welcome (indeed feel free to open an issue (or a discussion!) for the explict purpose of triage if it makes sense to you, I'm open to ideas.

Talk soon!

On Sat, Jan 2, 2021, at 23:46, Allan Smith wrote:

Never worth releasing on a red build.

If you need help resolving the build I'm happy to help resolve the issues.

Cheers

On Sat, 2 Jan 2021, 23:35 Gonzalo Bulnes Guilpain, notifications@github.com wrote:

Note: I'll hold on releasing v1.17.1 until I have a better idea of what to do with #367 https://github.com/gonzalo-bulnes/simple_token_authentication/issues/367. (I'd rather not release on a red build.)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gonzalo-bulnes/simple_token_authentication/pull/359#issuecomment-753468523, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4INPV3ECFTO4NWT2GNRRTSX4HJLANCNFSM4LXNRI5Q .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/gonzalo-bulnes/simple_token_authentication/pull/359#issuecomment-753469682, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMLI64W7CBU5EBG2PR5NN3SX4ITPANCNFSM4LXNRI5Q.

gonzalo-bulnes commented 3 years ago

Follow up: I've created a Project dedicated to sharing context and enabled Discussions.