update in the version of the gems

gonzalo-bulnes / simple_token_authentication

Simple (and safe*) token authentication for Rails apps or API with Devise.

GNU General Public License v3.0

1.51k stars 238 forks source link

Closed wjorellano closed 1 year ago

oskarpearson commented 1 year ago

Hi @wjorellano - I think it may be best to close this in favour of these two? 391 changes numerous items in addition to your changes

gonzalo-bulnes commented 1 year ago

Hi @wjorellano,

@oskarpearson is correct, adding support for a new Rails version usually requires a few more changes:

adding test scenarios for the new version of Rails (at the minimum)
and often add or remove a dependency here and there (because newer version of Rails tends to remove features that get moves to new gems, for example activemodel_serializers).

Thanks for you PR anyway! I've set up #391 to close it automatically when it gets merged :slightly_smiling_face: