search

gonzalo / gphoto2-updater

Gphoto2 compiler and installer script. This script was initially created for Raspbian and Raspberry Pi but it is also tested for Ubuntu and Debian Jessie & Wheezy.
http://github.com/gonzalo/gphoto2-updater
292 stars 72 forks source link

Updated gphoto2 and libgphoto2 links to use the new github repository #29

Closed scribblemaniac closed 8 years ago

scribblemaniac commented 9 years ago

Since gphoto2 has moved to GitHub, we might as well update the links accordingly. This change provides a modest security improvement as the download is now over HTTPS and is not subject to SourceForge's recent sketchy business practices.

I do not have a Raspberry Pi to test this on at the moment, and I don't anticipate that changing soon. I am fairly confident this change will work fine, but if someone could test it for me that would be much appreciated.

gonzalo commented 9 years ago

Thanks @scribblemaniac , yesterday I've taking a look to the new GitHub repository of gphoto2. Unfortunately update links is not enought to get this script updated. It seems that some parts of the code are also different (configure file has gone and autoconf doesn't seems to solve the problem). I'll wait for a while in order to be sure that respository migration is complete.

scribblemaniac commented 9 years ago

Sure thing, keep me posted!

gonzalo commented 9 years ago

New RC version! https://github.com/gonzalo/gphoto2-updater/tree/GitHub-integration integrates the new github repositories and libusb 1.0.20. Please feel free to test it! As soon as i can test it over my Raspberry Pi I'll merge it to master version

scribblemaniac commented 9 years ago

Looks good! Although I think it would be nice to have the option to install the latest stable version rather than the developer version. Could we perhaps add a flag to control this?

gonzalo commented 9 years ago

Marcus has confirmed that next gphoto2 version (2.5.9) will be released in GitHub. With current code this update should be automatic. Master branch is the unique branch so it should be considered as "stable/development" version.

Maybe I could introduce a "release" option in order to select the gphoto2 version you want to download, but could hard to control compilation.

scribblemaniac commented 9 years ago

I wouldn't usually consider the master branch stable. New features haven't been thoroughly tested and it's probably not uncommon for bugs or errors to be introduced when code is pulled/committed.

Adding a release option could indeed make compilation more difficult as well as making the script significantly more complex. These issues could be addressed by having two scripts instead of one. The first script would be the one currently on the GitHub-integration and would build the latest code straight from the github repository. The second script would be like the one currently in this PR, and would only compile the latest stable versioned release (2.5.9 when it comes out for example). You would still only need to run one command to install gphoto2, the url would just change depending on whether you are looking for stability or the latest features. This doesn't really require any more work from us at the moment because we already have both of these scripts. We would still have to maintain the second script by updating the version, but gphoto2's release cycle is pretty long so that isn't really that big of an issue in my opinion. What are you're thoughts on an approach like this?

gonzalo commented 9 years ago

While I'm considering how to manage releases, I've tested new release in my rasperry Pi. Happy to announce that works correctly!

Probably I'll wait for the next release in github to define the strategy with releases. Meanwhile github-integration will integrate the lastest code updates.

scribblemaniac commented 8 years ago

Well now that the next release is out, are you ready to define a strategy? (I'm not rushing you, just curious)

gonzalo commented 8 years ago

Since Marcus has officially released 2.5.9 version in github (also in sourceforge) an option coud be updating github-integration branch with a selector to download and compile lastest stable release or master (development) branch. As I talked with marcus, master branch includes patches and support for new cameras that many people would appreciate, so having a different branch for lastest updates could be the opposite of the spirit of this project. What do you think?

By the way, thanks for your interest in this project. I highly appreciate it.

scribblemaniac commented 8 years ago

I totally agree. Both stable and master have their benefits and drawbacks, and it should be up to the user to determine which one is right for them. Whichever one you choose to make the default is fine with me, as long as there is the option for either.

By the way, thanks for your interest in this project. I highly appreciate it.

No problem, the pleasure's mine :smile:

gonzalo commented 8 years ago

Happy to anounce new version of GitHub-integration branch. Now with more vitamins!

Now you can choose between last stable release or master branch ( = current development version 2.5.9.1). Both take code from github repositories.

Checked with ubunbtu 14.04 and raspbian wheezie.