search

gonzaloalonsod / pywebkitgtk

Automatically exported from code.google.com/p/pywebkitgtk
Other
0 stars 0 forks source link

pkg-config variable 'codegendir' should be taken from pygobject-2.0 #47

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
The configure script computes a PYGTK_CODEGENDIR variable by reading the 
pkg-config variable 'codegendir' from the pygtk-2.0 project. The functionality 
has been moved to pygobject with a backwards-compatibility variable being kept 
in pygtk-2.0. However, the value of this variable is such that it works only if 
pygobject and pygtk are installed with the same prefix. This may be the case 
most of the time but pywebkitgtk cannot be built if they are installed in 
different places for some reason.

The solution would at least include this patch:

diff -u -d -r pywebkitgtk-1.1.7/configure.ac 
pywebkitgtk-1.1.7-patched/configure.ac
--- pywebkitgtk-1.1.7/configure.ac  2009-10-03 05:35:23.000000000 +0200
+++ pywebkitgtk-1.1.7-patched/configure.ac  2010-07-11 21:39:27.474455577 +0200
@@ -66,7 +66,7 @@

 dnl check for pygtk codegen dir
 AC_MSG_CHECKING(for pygtk codegendir)
-PYGTK_CODEGENDIR=`$PKG_CONFIG --variable=codegendir pygtk-2.0`
+PYGTK_CODEGENDIR=`$PKG_CONFIG --variable=codegendir pygobject-2.0`
 AC_SUBST(PYGTK_CODEGENDIR)
 AC_MSG_RESULT($PYGTK_CODEGENDIR)

Also, renaming the PYGTK_CODEGENDIR variable accordingly might be a good idea.

Original issue reported on code.google.com by tho...@thomas-lotze.de on 12 Jul 2010 at 3:31

GoogleCodeExporter commented 8 years ago 
Thanks Thomas. Patch applied - 
http://github.com/jmalonzo/pywebkitgtk/commit/452fdfd1cbb0697e7ba4c1d39e0c7f05af
b25c8f

Cheers.

Original comment by jmalo...@gmail.com on 7 Aug 2010 at 8:42