search

gonzaloaune / GCMPushPlugin

Push notifications for Cordova (GCM & Native support)
MIT License
37 stars 20 forks source link

Changed and added (a lot of...) Android functionality #6

Open akreienbring opened 9 years ago

akreienbring commented 9 years ago

Hi Gonzalo, thanks for the ground work you made.

I was in need of a plugin that uses the new GCM implementation. E.g. subscribing to topics was not possible with the (deprecated) phongegap-push-plugin.

So I found yours and reworked the Android part. It now has much more functionality and mimics the behaviour of phongegap-push-plugin in most of its parts.

Unfortunatly I don't think that the iOS implementation is still working because I changed your callback philosophy to an event based approach.

I hope you will merge this request and adjust the iOS code to my proposals.

Greetings, André

akreienbring commented 8 years ago

Gonzalo, why don't you merge this?

gonzaloaune commented 8 years ago

Im reviewing this right now and testing, I will keep you posted throughout the day. Thanks @akreienbring for your contribution.

poacher2k commented 8 years ago

Any update on this @gonzaloaune ? Seems like a lot of good stuff here.

Edit: Just noticed "His plugin has iOS support, but I think I broke the compatibility with my changes.", which may be the reason why the merging is taking a while?

gonzaloaune commented 8 years ago

Yes, I'm actually updating the iOS side since this pull request broke that functionality. I expect to have it ready by later today.

telemakhos commented 8 years ago

Any update regarding this?

genesy commented 8 years ago

@gonzaloaune any update on your review? will be using your plugin if you get this merged :)

jellomaster commented 8 years ago

I'm also looking forward to this getting merged.

telemakhos commented 8 years ago

I moved to this plugin...

https://github.com/phonegap/phonegap-plugin-push/pull/282