search

gonzalocasas / node-proxy-middleware

proxy as middleware
MIT License
146 stars 65 forks source link

Causes weird behaviour when a url without the http:// is not specified #15

Closed validkeys closed 10 years ago

validkeys commented 10 years ago

I'm using this with ember-cli and just discovered the following:

This is a low-priority aesthetic thing, but a warning would be nice when an invalid URL type was specified for the proxy. Here is an example of what we get in the console

TypeError: Cannot read property 'length' of null at slashJoin (/[PATH]/node_modules/ember-cli/node_modules/proxy-middleware/index.js:83:9)

Thanks!

andrewrk commented 10 years ago

feel free to make a pull request.