search

gonzofish / angular-librarian

An Angular 2+ scaffolding setup for creating libraries
https://www.npmjs.com/package/angular-librarian
MIT License
91 stars 9 forks source link

Adding protractor configuration #57

Open el-davo opened 7 years ago

el-davo commented 7 years ago

Following discussion on - https://github.com/gonzofish/angular-librarian/issues/56 here is the pr. Let me know what you think?

gonzofish commented 7 years ago

I'm going to take a look at this tonight.

After an initial look, I think we might need to make the approach more general for scaffolding, but since I don't really know Protractor or its best practices, I may be wrong.

el-davo commented 7 years ago

Thanks for the awesome feedback. Again please feel free to decline this pr if you feel it can be improved. I will gladly give it another stab at a future date. I wish i had more time to commit to this 🥇

gonzofish commented 7 years ago

Thanks for contributing. It's really nice to have people commit time to something you've done. I think the changes are pretty light, so do them when you have a shot, no rush.