good-gym / opendata

Documentation, Changelog and Issues related to the Goodgym RPDE endpoint
1 stars 0 forks source link

add more fields such as meetingPoint #2

Closed tomoakley closed 7 years ago

tomoakley commented 8 years ago

Hi there,

The description field in some of the data items has info like meetingPoint included...would be super useful if this could be a separate field in the data. Also would be great to have more transparency over equipment/clothing needed (e.g protective clothing). Lastly, a sessionLeader or similar field, for who is leading the session, with their contact details, would be great too.

Thanks!

tomoakley commented 8 years ago

A session end time or duration would be great too.

manzan46 commented 8 years ago

Do you have a list of all this kind of field somewhere?

tomoakley commented 8 years ago

Hi @manzan46, this is the list of fields which open sessions, another activity provider, includes in their endpoint: https://github.com/opensessions/opendata. There might be one on the OpenActive spec somewhere, @nickevansuk might know more about this.

manzan46 commented 8 years ago

Ok will have a look and try to add some

nickevansuk commented 8 years ago

@manzan46 - I know this is going to be a focus of the OpenActive W3C Community Group (https://www.w3.org/community/openactive/). Worth joining in if you're interested in contributing to the list of standard fields for the sector. (@ldodds FYI)

tomoakley commented 8 years ago

Also @manzan46, the description field contains HTML/markdown markup which I'm not sure should be in an OpenActive field...(each frontend where the data is displayed should be the ones who decide on formatting and stuff). Thanks for your efforlets!

tomoakley commented 8 years ago

Hi @manzan46, any progress on this? No problem if not! (I'm at imin tomorrow [also a student, so I work 1 day per week with imin]) and would love to get Goodgym data live on GetActive but this is currently blocking it :(

manzan46 commented 8 years ago

I'll have a look this afternoon for all the additional field.

For the description it will be a bit more tricky as our trainers write it as markdown and we store it as they write it. but might find a way to remove all makdown.

Ax

On 15 November 2016 at 11:05, Tom Oakley notifications@github.com wrote:

Hi @manzan46 https://github.com/manzan46, any progress on this? No problem if not! (I'm at imin tomorrow [also a student, so I work 1 day per week with imin]) and would love to get Goodgym data live on GetActive but this is currently blocking it :(

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/goodgym-oa/opendata/issues/2#issuecomment-260612979, or mute the thread https://github.com/notifications/unsubscribe-auth/ABBbWmHo33h0jekhaJn1bRMjDX4D9t7oks5q-ZIWgaJpZM4Kuxaa .

GOODGYM AXEL MANZANO - Tech Team 020 34323920 | 07706 414616 http://www.goodgym.org facebook https://www.facebook.com/goodgym | @goodgym http://www.twitter.com/goodgym | instagram http://www.instagram.com/goodgym GoodGym, Somerset House Strand, London, WC2R 1LA

manzan46 commented 8 years ago
{
  "state" : "updated",
  "kind" : "GroupRun",
  "id":2661,
  "modified" : "2016-10-11T12:21:18.538Z",
  "data":
    {
      "name" : "Monthly visit to Cecil Sharp House #runandtalk starter session!",
      "strapline" : "Doing that good thing! ",
      "description" : "GoodGym Camden is the best way to get fit in North London, we meet every week at 6.45pm, there's a short intro and we aim to leave at 7pm. \nWe are a fun and sociable group which does good and gets fit together. We welcome all abilities but ask that you are able to run for at least 15 minutes, don't worry though we keep together as a group and no-one is left behind! Come along and join us!\nWe'll be returning to Cecil Sharp House (http://www.cecilsharphouse.org/) to help garden and keep the area tidy, we'll be running around 4km overall and splitting into different groups based on speed. This is a monthly task which helps keep this amazing building and gardens clean and ready! \nThis week at GoodGym Camden we will be doing a #runandtalk starter session. The campaign aims to improve mental health through running in England by:\nGetting people talking about mental health, sharing their experiences and removing stigma\nRaising awareness of mental health problems\nSupporting people experiencing mental health problems to be physically active through running, whether that is to support them in starting, returning to or continuing to run\nAfter the run we'll head for a lemonade at the local pub - it's just around the corner - it's a great opportunity to learn more about what GoodGym does, what we've been up to in Camden and how you might get further involved and they do some cracking sweet potato fries too!\nIt's going to be a great evening!\nPaul (mailto:paul@goodgym.org) - Camden Trainer\n",
      "markdown_description" : "GoodGym Camden is the best way to get fit in North London, we meet every week at 6.45pm, there's a short intro and we aim to leave at 7pm. \r\n\r\nWe are a fun and sociable group which does good and gets fit together. We welcome all abilities but ask that you are able to run for at least 15 minutes, don't worry though we keep together as a group and **no-one is left behind!** Come along and join us!\r\n\r\nWe'll be returning to [Cecil Sharp House](http://www.cecilsharphouse.org/) to help garden and keep the area tidy, we'll be running around 4km overall and splitting into different groups based on speed. This is a monthly task which helps keep this amazing building and gardens clean and ready! \r\n\r\nThis week at GoodGym Camden we will be doing a #runandtalk starter session. The campaign aims to improve mental health through running in England by:\r\n\r\n1. Getting people talking about mental health, sharing their experiences and removing stigma\r\n2. Raising awareness of mental health problems\r\n3. Supporting people experiencing mental health problems to be physically active through running, whether that is to support them in starting, returning to or continuing to run\r\n\r\nAfter the run we'll head for a lemonade at the local pub - it's just around the corner - it's a great opportunity to learn more about what GoodGym does, what we've been up to in Camden and how you might get further involved *and* they do some cracking sweet potato fries too!\r\n\r\nIt's going to be a great evening!\r\n\r\n[Paul](mailto:paul@goodgym.org) - Camden Trainer",
      "start_time" : "2016-10-12T18:45:00.000Z",
      "start_point": ["Somers Town Community Centre", "150 Ossulston Street", "London", "NW1 1EE"],
      "end_time" : "2016-10-12T20:40:00.000Z",
      "access_notes" : "",
      "access_other_information" : "There's space to change and leave bags and toilets.  We're not planning to do anything purposefully dangerous, but GoodGym takes no responsibility for your safety during group runs, you participate at your own risk. Participants accept full responsibility for items stored at Somers Town Community Centre, and Somers Town Community Centre \u0026 GoodGym will not be held liable for any losses / damages.",
      "area" : "Camden",
      "distance":null,
      "price":0,
      "minAgeRestriction":18,
      "starter_session":false,
      "leader" : "Paul Bown",
      "hasCoaching":true,
      "contactEmail" : "paul@goodgym.org",
      "photos":[ /*all_photos in difeerent format*/ ],
      "slug" : "monthly-visit-to-cecil-sharp-house",
      "uuid" : "monthly-visit-to-cecil-sharp-house",
      "url" : "http://www.goodgym.org/happenings/monthly-visit-to-cecil-sharp-house"}
    }
}

Hey @tomoakley This is what I got so far, let me know if you need some field renamed or more detailed before I push it live

tomoakley commented 8 years ago

Hey @manzan46 this looks great! I'll review it properly tomorrow but thanks for your effort on this, much appreciated.

One issue I've just noticed: minAgeRestriction should be minAge. Not a big one but I think for similarity with other OA implementations this would be a good change.

EDIT: just looked at the opensessions implementation, it says minAgeRestriction. Ignore me!

tomoakley commented 8 years ago

@manzan46 this looks good, would be great to get it live. What data will go in access_notes?

manzan46 commented 8 years ago

@tomoakley it's often which entrance to get to if it's a big building, or which person to contact at arrival

manzan46 commented 8 years ago

@tomoakley it's live let me know if you need any changes