good-idea / sane-shopify

MIT License
212 stars 15 forks source link

Validate shopify storefront name input, add .myshopify.com to element #120

Open colinxr opened 4 years ago

colinxr commented 4 years ago

I can enter my store url and storefront API Token in the fields on the "Shopify" tab, but when I hit "Save Credentials", the page just flashes without any feedback.

When I navigate to desk and then click back to the Shopify Tab, the values I entered previously are gone, and the fields are just blank.

Worth mentioning, I added sanity to an existing vue project. The folder structure looks like this:

/project-root
- /sanity 
- /src
- /public
- /dist
- .env
- vue.config.js
- babel.config.js 
- package.json

I am new to Sanity, so please forgive any foolish mistakes. Any help much appreciated!

good-idea commented 4 years ago

Hiya, sorry about this, I'll look into it right now ~ i probably messed something up :|

trompx commented 4 years ago

Hey @good-idea, Just to let you know that I am having the same issue, did you come up with a fix? Thanks a lot for making the integration with shopify less painful by the way!

trompx commented 4 years ago

The message to enter the shopify domain was a bit misleading. By looking at the request, we had to omit the .myshopify.com so just enter for instance myshop and not myshop.myshopify.com.

good-idea commented 4 years ago

Hey, sorry for the delay over here! I'm glad you figured it out ~ I'm going to change the title of this issue to auto-include the .myshopify.com text in the input field and add better validation to this field. Thank you for opening the issue and checking back in!