search

good-idea / sane-shopify

MIT License
212 stars 15 forks source link

Option to set synced products/collections as draft #94

Open leo-cheron opened 4 years ago

leo-cheron commented 4 years ago

When products are synced from Shopify, they are currently automatically marked as published in Sanity.

This behaviour can be troublesome if we decide to extend shopifyProduct / shopifyCollection with required field (a slug, for instance) as it could prevent the front-end to work as expected.

Would it be possible to add a saneShopifyConfig option to create drafts instead of published documents on Shopify sync document creation?

Todo:

good-idea commented 4 years ago

Hmm, this is a good thought. Were you thinking that this would happen only when new documents are created, or for updates / re-syncs as well?

leo-cheron commented 4 years ago

Hmm, this is a good thought. Were you thinking that this would happen only when new documents are created, or for updates / re-syncs as well?

I think it should only be stated as draft on creation because it needs to be manually populated before the first publication. Then, if it has already been published once, it would make sense to automatically republish it on Shopify sync (let's avoid republishing manually numerous products !).

good-idea commented 4 years ago

Got it, that sounds good. I added this to the 1.1 milestone, but will aim to get it into 1.0 since I don't think it will be that complicated.

leo-cheron commented 4 years ago

Got it, that sounds good. I added this to the 1.1 milestone, but will aim to get it into 1.0 since I don't think it will be that complicated.

Thank you sir, this lib begins to be quite mature and I'm planning to use it for production on my next project. Keep up the good work, Sanity really needs a solid Shopify sync plugin!