goodbotai / karma

Experience sampling bot
BSD 2-Clause "Simplified" License
7 stars 0 forks source link

Remove all references to http.genericCatchRejectedPromise #113

Closed urbanslug closed 6 years ago

urbanslug commented 6 years ago

Environment

All

Expected behavior

There should be no reference to http.genericCatchRejectedPromise because this function was moved to the logging module in borq v0.0.1-alpha.31

Actual behavior

There are references to this function which trigger an error for example:

You have triggered an unhandledRejection, you may have forgotten to catch a Promise rejection:
TypeError: http.genericCatchRejectedPromise is not a function
    at services.getUser.then.catch (/app/lib/user.js:69:16)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:160:7)
{
  "type": "Promise rejected",
  "text": "Failed to fetch profile in createUserAndStartConversation: [object Object]",
  "level": "error",
  "message": "",
  "timestamp": "2018-03-16T01:42:39.890Z"
}

Implementation plan