Closed goodboy closed 1 year ago
interesting i think 38326e8 makes the debugger tests pass that were failing on last run. I did a little local manual testing and it seems there can be transient failures on teardown..
I'm not sure if we should write an independent test to catch this since it's more of an auxillary teardown error that shouldn't (often) be a direct issue?
In response to a weird issue discovered by @guilledk where if you pass in a
mngrs=(<generator comprehension>)
, you end up with an empty sequence in the loop insidetrionics.gather_contexts()
and then a hang due to waiting on theall_entered: trio.Event
just after the loop.This solves the issue by greedly converting the
mngrs
sequence to a list and ensuring its size and otherwise raising aValueError
.Further TODO for this to land:
pytest
parametrization is janky..Other additions part of this patch:
open_actor_cluster()
helper such that any kwarg toopen_root_actor()
can be used