Ipc failure while streaming

goodboy / tractor

A distributed, structured concurrent runtime for Python (and friends)

GNU Affero General Public License v3.0

271 stars 12 forks source link

Ipc failure while streaming #346

Closed goodboy closed 1 year ago

goodboy commented 1 year ago

Variety of streaming related teardown fixes for when IPC goes down before streams are terminated gracefully. Mostly discovered during dev of initial draft of https://github.com/pikers/piker/pull/420.

TODO:

[x] solve issue in this history causing #345 => dropping 5dc07f0 did it
[x] add more specific tests (particularly for b2971733c6) to match each of these "fixes" 😂

goodboy commented 1 year ago

Lol.. ok so its 5dc07f0..

No idea why yet, but dropping that commit for this history and gonna rebase all dependents.

goodboy commented 1 year ago

Lul, and turns out ba6a2b1 causes the test_context_streaming_semtantics suite to hang 😂

So gonna drop that one for now as well..