search

goodboy / tractor

A distributed, structured concurrent runtime for Python (and friends)
GNU Affero General Public License v3.0
271 stars 12 forks source link

Switch to `pdbp` 🏄🏼 #358

Closed goodboy closed 1 year ago

goodboy commented 1 year ago

A ton of thanks to @mdmintz for the fork and fix of pdbpp in the new and improved pdbp: https://github.com/mdmintz/pdbp

It would seem pretty much all the outstanding issues we had with pdbpp are non-existent in the new project 💃🏼 , so i think other then running this in my production dev eng for a bit, we can probably just land this pronto 😎

Deatz of previous issues that seem to now be resolved:

mdmintz commented 1 year ago

There's a new release of pdbp - 1.3.0 - https://github.com/mdmintz/pdbp/releases/tag/v1.3.0

goodboy commented 1 year ago

@mdmintz already tested manually and our test suite 🏄🏼

Should i pin to latest in our install script?

mdmintz commented 1 year ago

@goodboy I'm working on the update for the extra highlighting you wanted. Should be ready soon.

mdmintz commented 1 year ago

pdbp 1.3.1 is available, in case anyone missed the news.

goodboy commented 1 year ago

@mdmintz thanks! been trying it out the last day or so.

I'm still slightly confused on the truncate defaults i think? Not sure whether we want it disabled or not to keep vertical spacing between lines always consistent?

mdmintz commented 1 year ago

A new release of pdbp is available - https://github.com/mdmintz/pdbp/releases/tag/v1.4.0

goodboy commented 1 year ago

Weird, debugger tests failed even though they didn't before?

Removed the pdbpp dep from test reqs, let's see if that does it?

goodboy commented 1 year ago

Only last thing was maybe removing the pyreadline3 dep from the setup since it was only required on windows IIRC?

Not sure it's a big deal enough to block this and we probably won't get clarity until @mdmintz returns from vaca anyway 😂

So gonna land once stamped!