goodboy / tractor

A distributed, structured concurrent runtime for Python (and friends)
GNU Affero General Public License v3.0
265 stars 12 forks source link

Switching to pdbpp is making it impossible to install with pypy and git #364

Closed grizzlybearg closed 11 months ago

grizzlybearg commented 1 year ago

I get the followinf error when trying to install using pypy: ERROR: Packages installed from PyPI cannot depend on packages which are not also hosted on PyPI. tractor depends on pdbpp@ git+https://github.com/pdbpp/pdbpp@76c4be5#egg=pdbpp ; python_version > "3.9"

I can't install using git because I get this error: `PS C:\Users\user> pip install git+git://github.com/goodboy/tractor.git Defaulting to user installation because normal site-packages is not writeable Collecting git+git://github.com/goodboy/tractor.git Cloning git://github.com/goodboy/tractor.git to c:\users\user\appdata\local\temp\pip-req-build-ryqbr1ew Running command git clone --filter=blob:none --quiet git://github.com/goodboy/tractor.git 'C:\Users\user\AppData\Local\Temp\pip-req-build-ryqbr1ew' fatal: unable to connect to github.com: github.com[0: 20.87.225.212]: errno=Unknown error

error: subprocess-exited-with-error

× git clone --filter=blob:none --quiet git://github.com/goodboy/tractor.git 'C:\Users\user\AppData\Local\Temp\pip-req-build-ryqbr1ew' did not run successfully. │ exit code: 128 ╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip. error: subprocess-exited-with-error

× git clone --filter=blob:none --quiet git://github.com/goodboy/tractor.git 'C:\Users\user\AppData\Local\Temp\pip-req-build-ryqbr1ew' did not run successfully. │ exit code: 128 ╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.`

Zaczero commented 1 year ago

Such a good project, yet, I cannot install it.

goodboy commented 1 year ago

@Zaczero 😂

Yeah sorry our last alpha was borked on pypi... https://github.com/goodboy/tractor/issues/323

been meaning to do another release but it's just been lower on the TODO list.

Install from git should work no?

fatal: unable to connect to github.com: github.com[0: 20.87.225.212]: errno=Unknown error

Seems to be some non-tractor issue that @grizzlybearg experienced 🤔

@Zaczero @grizzlybearg RE the pdbpp thing, we aren't supporting it any more either so please migrate to pdbp as per https://github.com/goodboy/tractor/pull/358

If there's anything else I can help with please LMK.

I will try to get a new pypi release out this week.


ALSO, how does everyone feel about using poetry going forward?

grizzlybearg commented 1 year ago

@goodboy Installing from git also fails

goodboy commented 1 year ago

@grizzlybearg Hmm.

It's the same error as from OP yah?

Technically we haven't really tested nor claimed to support pypy if you're talking about the interpretter / JIT. I'm guessing you just mispelled PyPi? Maybe clarify that part 😉

In terms of installing with pip from github, maybe try cloning the rep and installing in editable mode?


ERROR: Packages installed from PyPI cannot depend on packages which are not also hosted on PyPI. tractor depends on pdbpp@ git+https://github.com/pdbpp/pdbpp@76c4be5#egg=pdbpp ; python_version > "3.9"

AGAIN, PyPi install are known to borked rn, i already linked the existing issue.

goodboy commented 1 year ago

On a related note, after having used poetry in a couple projects now I'm fairly convinced it's a much more sane way to go, and so likely as part of addressing whatever underlying issue is causing this, we'll use that re-packaging task to solve it 😎

Zaczero commented 1 year ago

This is a fresh ubuntu image with git, python, pip installed. None of the installation instructions from the README work.

image

image

goodboy commented 1 year ago

@Zaczero your 2nd command is timing out on the network? I'm not sure i can help much with that. AGAIN, the first pip install tractor IS KNOWN and listed in #323; we only need to do a new release to resolve this.

Either way try doing a from source install by cloning and cd-ing to the repor dir and running pip install -e ./

Will hopefully get to patching this all up and another release in the next month once a ton of patches get landed.

Zaczero commented 1 year ago

image

I'm not sure what more to express here. The problem seems isolated to the Tractor package in my case. It's possible that it's experiencing timeouts due to its continued use of the deprecated git:// protocol. As discussed in this GitHub blog post (https://github.blog/2021-09-01-improving-git-protocol-security-github/). I'm aware that numerous installation approaches exist. However, I'd kindly request that the functional methods be documented in the Installation section of the README.

goodboy commented 1 year ago

Ok well our CI thinks that installs work just fine, otherwise this job would fail 😉. Mind you this is doing manual sdist installs with python -m pip install dist/*.zip..

https://github.com/goodboy/tractor/actions/runs/6001334998/job/16275291910

However, I'd kindly request that the functional methods be documented in the Installation section of the README.

Yes indeedy 😂 we for sure do not want to have the legacy url syntax in there. I'm going to be pushing up some dev work today and will try to get the readme up to snuff for you to test

goodboy commented 1 year ago

As discussed in this GitHub blog post (https://github.blog/2021-09-01-improving-git-protocol-security-github/).

FWIW, we'll of course quickly accept a patch for this to the README 😉

Zaczero commented 1 year ago

Thank You!

goodboy commented 1 year ago

@Zaczero yah so there's quite a few dev branches + PRs that need to get landed before a release including:

goodboy commented 1 year ago

Ok so we need to switch to the https url form for the readme:

https://stackoverflow.com/a/20101940