goodby / csv

Goodby CSV is a high memory efficient flexible and extendable open-source CSV import/export library for PHP 5.3. 1. Memory Management Free This library designed for memory unbreakable. It will not be accumulated in the memory whole rows. The importer read CSV file and execute callback function line by line. 2. Multibyte support This library supports mulitbyte input/output: for example, SJIS-win, EUC-JP and UTF-8. 3. Ready to Use for Enterprise Applications Goodby CSV is fully unit-tested. The library is stable and ready to be used in large projects like enterprise applications.
MIT License
955 stars 148 forks source link

should be compatible with SplFileObject::fputcsv #56

Closed Siemienik closed 9 years ago

Siemienik commented 9 years ago
Message: Declaration of Goodby\CSV\Export\Standard\CsvFileObject::fputcsv() should be compatible with SplFileObject::fputcsv($fields, $delimiter = NULL, $enclosure = NULL, $escape = NULL)

Anyone know why? PHP 5.5.21-pl0-gentoo (cli) (built: Jan 26 2015 18:13:10) Copyright (c) 1997-2014 The PHP Group Zend Engine v2.5.0, Copyright (c) 1998-2014 Zend Technologies with Zend OPcache v7.0.4-dev, Copyright (c) 1999-2014, by Zend Technologies

Siemienik commented 9 years ago

https://bugs.php.net/bug.php?id=68479

Siemienik commented 9 years ago

could I please for quick accept pull request?