goodeggs / fake-eggs

create all sorts of Good Eggs style fake data!
1 stars 1 forks source link

Add fake.creditCard.{number,verificationCode,expiry} #75

Open serhalp opened 3 years ago

serhalp commented 3 years ago

Add some credit card factories nested under fake.creditCard:

Are these last two useful? Either way, I'd propose to nest the CC number method under fake.creditCard.number() for future extensibility.

risharma commented 3 years ago

Additional properties to consider:

serhalp commented 3 years ago

@risharma do we have any current use cases for those?

risharma commented 3 years ago

@risharma do we have any current use cases for those?

https://github.com/goodeggs/garbanzo/blob/master/src/graphql/data_sources/user/index.unit.spec.ts#L206-L208

P.S.: I'm fixing to correctly generate last4 in https://github.com/goodeggs/garbanzo/pull/7766