goodeggs / generator-goodeggs-npm

Generate npm modules the Good Eggs way
1 stars 0 forks source link

Level up private package generation #16

Closed hurrymaplelad closed 9 years ago

hurrymaplelad commented 9 years ago

Biggest win is package.json publishConfig, preventing us from publishing private modules anywhere but our private registry.

Other win is test coverage. Especially around the most critical piece, spacing between badges in README.md!

Fixes #13, although I'm not sure about the CODE_OF_CONDUCT part. I think it's meant to apply to open source projects, but doesn't seem harmful to leave it in. Strong feelings?

PS, have you all see scoped packages coming in npm 1.5? @goodeggs/module-name always forwards to a configured private repo! :balloon:

hurrymaplelad commented 9 years ago

Also, project level .npmrc files are in npm 1.4+. Perhaps we should generate one of those to, so private packages install their dependencies from our registry without configuration.

hazeledmands commented 9 years ago

So excited about scoped packages.

Nice job Adam!