search

goodeggs / goodeggs-money

Reliable money math with BigNumber wrapped inside Cents
MIT License
3 stars 0 forks source link

Typescript porting #14

Closed jonasgraterol closed 2 years ago

jonasgraterol commented 2 years ago

Porting to typescript

jonasgraterol commented 2 years ago

LGTM!

some comments to eliminate any types

Did you have chance to read my note related to those anys ?

jonasgraterol commented 2 years ago

LGTM! some comments to eliminate any types

Did you have chance to read my note related to those anys ?

Actually I gave those a try and TS is not complaining about the usage of instanceof, thank you !

jonasgraterol commented 2 years ago

Thanks for reviews 🙏