search

goodeggs / librato-node

A Node.js client for Librato (http://librato.com/)
MIT License
37 stars 26 forks source link

Counters are being recorded as gauges #36

Closed garnold closed 9 years ago

garnold commented 9 years ago

Heyo! I'm recording/sending 2 metrics to Librato, one using #measure (gauge) and the other using #increment (counter), however both are being recorded as gauges in Librato:

screenshot 2015-04-10 15 59 24

I believe this is because the librato.flush method in librato.coffee is not properly classifying metrics as counters and gauges, as required by the Librato API:

http://dev.librato.com/v1/post/metrics

bobzoller commented 9 years ago

The original ruby library I ported to node also represented increments as gauges... this is why things are the way they are. PR #27 switches increment to use counters, and just needs a tiny bit of love to get merged.

I have a few minutes... I'll see if I can't tackle it now, but I'll close this and you can watch #27.

garnold commented 9 years ago

Thanks @bobzoller . I've temporarily moved to librato-metrics while the counter issue here is sorted out.