search

goodeggs / librato-node

A Node.js client for Librato (http://librato.com/)
MIT License
37 stars 26 forks source link

Use Librato 'counters' in addition to 'gauges' #37

Closed mmoskal closed 9 years ago

mmoskal commented 9 years ago

Currently the module reports increment() as Librato gauges, but librato also has a counter type (http://dev.librato.com/v1/post/metrics). This patch adds option counters:true to report increment() calls as counters.

mmoskal commented 9 years ago

After some experimenting, this is not as useful as I thought - librato expects the client to keep track of the counter, not only post increments.

garnold commented 9 years ago

@mmoskal That is actually the correct behavior. Other statistics collection frameworks, such as Collectd, work the same way. See discussion of #36 and #27. Would love it if you'd consider reopening this pull request :+1:

mmoskal commented 9 years ago

Re-opened, and updated to make it work in non-distributed setting.

garnold commented 9 years ago

Thanks @mmoskal !

bobzoller commented 9 years ago

@mmoskal @garnold I think #27 / #40 (which just landed) eliminates the need for this. It might still be nice to offer users the ability to choose gauges or counters for increment, but it seems like counters should be the default (and now they are).

I'm going to close this until we hear folks need the choice.