goodfella / googletest

Automatically exported from code.google.com/p/googletest
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Problems running scripts/test/Makefile #332

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Is scripts/test/Makefile supposed to work out-of-the-box?

When making it, link fails with pthread errors. Adding ``-lpthread`` to the 
linking command makes it work.

Also, I get a deprecation warning from fuse_gtest_files.py:

../fuse_gtest_files.py output
../fuse_gtest_files.py:63: DeprecationWarning: the sets module is deprecated
  import sets

I'm using Python 2.6.5

Original issue reported on code.google.com by eliben on 19 Nov 2010 at 9:17

GoogleCodeExporter commented 9 years ago
Just to mention that the sets module has been deprecated since Python 2.6, and 
the set() type should be used instead (see 
http://docs.python.org/library/sets.html).

To make it work for both >= 2.6 and < 2.6 a simple usage test inside a 
"try...except" in the beginning of the file is customary in Python.

Original comment by eliben on 19 Nov 2010 at 9:20

GoogleCodeExporter commented 9 years ago
Thanks for the report. Makefile script fixed in SVN revision 514.

We are unlikely to fix the deprecation warning, though. The try-catch fix will 
make the code more complex while the benefit of it will be very small. Instead, 
at some future point, we will re-assess our support for Python 2.3 and replace 
the objects from the sets module with built-in sets.

Original comment by vladlosev on 19 Nov 2010 at 8:13